From 92de3895d7a45597befa543b553d50c742e3b89f Mon Sep 17 00:00:00 2001
From: TDLaouer <tdlaouer@protonmail.com>
Date: Wed, 9 Jul 2025 13:10:38 +0200
Subject: [PATCH] clean css and fetch image uniterally

---
 src/App.vue                        |  3 ++
 src/assets/base.css                |  1 -
 src/components/Card.vue            | 12 ++---
 src/components/Game.vue            | 57 +++++++++++++----------
 src/components/LandingPage.vue     | 18 +++++---
 src/components/Login.vue           | 74 ------------------------------
 src/components/Result.vue          | 18 +++++---
 src/main.ts                        |  2 +-
 src/route.ts                       | 11 +----
 src/services/visualAssetService.ts |  6 +--
 src/stores/userStore.ts            | 32 -------------
 src/types/types.ts                 |  8 +++-
 12 files changed, 79 insertions(+), 163 deletions(-)
 delete mode 100644 src/components/Login.vue
 delete mode 100644 src/stores/userStore.ts

diff --git a/src/App.vue b/src/App.vue
index 0f3ec68..9f95c23 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -2,6 +2,9 @@
 
 <template>
   <div class="container">
+    <header>
+      <h1>Smash or Pass</h1>
+    </header>
     <main>
       <router-view :key="$route.fullPath"></router-view>
     </main>
diff --git a/src/assets/base.css b/src/assets/base.css
index 3213c84..305d640 100644
--- a/src/assets/base.css
+++ b/src/assets/base.css
@@ -68,7 +68,6 @@
 *,
 *::before,
 *::after {
-  box-sizing: border-box;
   margin: 0;
   font-weight: normal;
 }
diff --git a/src/components/Card.vue b/src/components/Card.vue
index a7d5c17..48986ef 100644
--- a/src/components/Card.vue
+++ b/src/components/Card.vue
@@ -4,14 +4,14 @@
     :class="{ 'slide-right': animateTo === 'smash', 'slide-left': animateTo === 'pass' }"
   >
     <img
-      :src="image.imageSrc"
-      :alt="image.name"
+      :src="image?.imageSrc"
+      :alt="image?.name"
       class="card-image"
       @click="openImageInNewTab"
       style="cursor: pointer"
     />
     <div class="controls">
-      <h2>{{ image.name }}</h2>
+      <h2>{{ image?.name }}</h2>
       <div>
         <button class="button button-pass" @click="choose('pass')">PASS</button>
         <button class="button button-smash" @click="choose('smash')">SMASH</button>
@@ -22,11 +22,11 @@
 
 <script setup lang="ts">
 import { ref } from 'vue'
-import type { FrontVisualAsset, VisualAsset } from '@/types/types.ts'
+import type { FrontVisualAssetWithSrc } from '@/types/types.ts'
 
 const props = defineProps({
   image: {
-    type: Object as () => FrontVisualAsset,
+    type: Object as () => FrontVisualAssetWithSrc | null,
     required: true,
   },
 })
@@ -44,7 +44,7 @@ const choose = (choice: string) => {
 }
 
 const openImageInNewTab = () => {
-  window.open(props.image.imageSrc, '_blank')?.focus()
+  window.open(props.image?.imageSrc, '_blank')?.focus()
 }
 </script>
 
diff --git a/src/components/Game.vue b/src/components/Game.vue
index 0baa62c..129fee7 100644
--- a/src/components/Game.vue
+++ b/src/components/Game.vue
@@ -1,38 +1,49 @@
 <template>
-    <div v-if="visualAssetStore.visualAssets.length">
-        <Card
-          v-if="currentIndex < visualAssetStore.visualAssets.length"
-          :image="visualAssetStore.visualAssets[currentIndex]"
-          @choose="handleChoice"
-        />
-        <Result
-          v-else
-          :smashList="smashList"
-          :passList="passList"
-          @restart="restart"
-        />
-      </div>
+  <div v-if="visualAssetStore.visualAssets.length">
+    <Card
+      v-if="currentIndex < visualAssetStore.visualAssets.length"
+      :image="currentImage"
+      @choose="handleChoice"
+    />
+    <Result v-else :smashList="smashList" :passList="passList" @restart="restart" />
+  </div>
 </template>
 
 <script setup lang="ts">
 import Card from './Card.vue'
 import Result from './Result.vue'
-import { ref } from 'vue'
-import type { FrontVisualAsset, VisualAsset } from '@/types/types'
-import { useVisualAssetStore } from '@/stores/visualAssetStore';
-import router from '@/route';
+import { computed, ref, watch } from 'vue'
+import type { FrontVisualAsset, FrontVisualAssetWithSrc } from '@/types/types'
+import { useVisualAssetStore } from '@/stores/visualAssetStore'
+import router from '@/route'
+import { fetchVisualAssetById } from '@/services/visualAssetService'
 
-const visualAssetStore = useVisualAssetStore();
+const visualAssetStore = useVisualAssetStore()
 const currentIndex = ref(0)
 
-const smashList = ref<FrontVisualAsset[]>([])
-const passList = ref<FrontVisualAsset[]>([])
+const smashList = ref<FrontVisualAssetWithSrc[]>([])
+const passList = ref<FrontVisualAssetWithSrc[]>([])
+
+const currentImage = ref<FrontVisualAssetWithSrc | null>(null)
+
+watch(
+  () => visualAssetStore.visualAssets[currentIndex.value],
+  async (newImage: FrontVisualAsset) => {
+    if (newImage) {
+      currentImage.value = await fetchVisualAssetById(newImage._id)
+    } else {
+      currentImage.value = null
+    }
+  },
+  { immediate: true },
+)
 
 const handleChoice = (choice: string) => {
+  if (!currentImage.value) return
   if (choice === 'smash') {
-    smashList.value.push(visualAssetStore.visualAssets[currentIndex.value])
+    smashList.value.push(currentImage.value)
   } else {
-    passList.value.push(visualAssetStore.visualAssets[currentIndex.value])
+    passList.value.push(currentImage.value)
   }
   currentIndex.value++
 }
@@ -44,4 +55,4 @@ const restart = () => {
   visualAssetStore.clear()
   router.push({ name: 'landing-page' })
 }
-</script>
\ No newline at end of file
+</script>
diff --git a/src/components/LandingPage.vue b/src/components/LandingPage.vue
index 2aa6320..351b483 100644
--- a/src/components/LandingPage.vue
+++ b/src/components/LandingPage.vue
@@ -1,13 +1,12 @@
 <template>
   <div class="flex-container">
-    <h1>Smash or Pass</h1>
     <ul class="collection-list">
       <li class="collection-item" v-for="(collection, name) in groupedAssets" :key="name">
         <span class="collection-name">{{ name }}</span>
         <button class="button button-start" @click="startGame(name)">Start</button>
       </li>
     </ul>
-    <UploadImages></UploadImages>
+    <UploadImages v-if="isAdmin"></UploadImages>
   </div>
 </template>
 
@@ -34,6 +33,10 @@ onMounted(() => {
     })
 })
 
+const isAdmin = computed(() => {
+  return false
+})
+
 const groupedAssets = computed(() => {
   const groupByCollection: Record<string, FrontVisualAsset[]> = {}
   for (const asset of assets.value) {
@@ -58,17 +61,20 @@ const startGame = (collection: string) => {
   flex-direction: column;
   align-items: center;
   justify-content: center;
+  width: 100%;
+  max-width: 900px;
+  margin: 0 auto;
 }
 
 .collection-list {
   width: 100%;
-  max-width: 400px;
-  padding: 0;
-  margin: 1.5rem 0;
+  max-width: 800px;
+  padding: 0 2rem;
+  margin: 2rem 0;
   list-style: none;
   display: flex;
   flex-direction: column;
-  gap: 1rem;
+  gap: 2rem;
 }
 
 .collection-item {
diff --git a/src/components/Login.vue b/src/components/Login.vue
deleted file mode 100644
index 4d2e7e6..0000000
--- a/src/components/Login.vue
+++ /dev/null
@@ -1,74 +0,0 @@
-<template>
-  <div class="login-container">
-    <h2>Login</h2>
-    <form @submit.prevent="login">
-      <div class="form-group">
-        <label for="username">Username</label>
-        <input id="username" v-model="username" type="text" required />
-      </div>
-      <div class="form-group">
-        <label for="password">Password</label>
-        <input id="password" v-model="password" type="password" required />
-      </div>
-      <button class="button" type="submit">Login</button>
-      <p v-if="error" class="error">{{ error }}</p>
-    </form>
-  </div>
-</template>
-
-<script setup lang="ts">
-import { ref } from 'vue'
-
-const username = ref('')
-const password = ref('')
-const error = ref('')
-
-const login = () => {
-  if (username.value === 'admin' && password.value === 'password') {
-    error.value = ''
-    // Replace with your actual login logic or navigation
-    alert('Login successful!')
-  } else {
-    error.value = 'Invalid username or password'
-  }
-}
-</script>
-
-<style scoped>
-.login-container {
-  max-width: 350px;
-  margin: 3rem auto;
-  padding: 2rem;
-  border-radius: 8px;
-  box-shadow: 0 2px 8px rgba(0, 0, 0, 0.07);
-  text-align: center;
-}
-.form-group {
-  margin-bottom: 1.25rem;
-  text-align: left;
-}
-label {
-  display: block;
-  margin-bottom: 0.5rem;
-  font-weight: 600;
-}
-input[type='text'],
-input[type='password'] {
-  width: 100%;
-  padding: 0.5rem;
-  border-radius: 4px;
-  border: 1px solid #ccc;
-  font-size: 1rem;
-}
-.button {
-  width: 100%;
-  background: #4f8cff;
-}
-.button:hover {
-  background: #2563eb;
-}
-.error {
-  color: #e74c3c;
-  margin-top: 1rem;
-}
-</style>
diff --git a/src/components/Result.vue b/src/components/Result.vue
index 91fa44b..6e861ef 100644
--- a/src/components/Result.vue
+++ b/src/components/Result.vue
@@ -24,23 +24,28 @@
 </template>
 
 <script setup lang="ts">
-import type { FrontVisualAsset } from '@/types/types.ts';
+import type { FrontVisualAssetWithSrc } from '@/types/types.ts'
+
 defineProps({
   smashList: {
-    type: Array<FrontVisualAsset>,
+    type: Array<FrontVisualAssetWithSrc>,
     required: true,
   },
   passList: {
-    type: Array<FrontVisualAsset>,
+    type: Array<FrontVisualAssetWithSrc>,
     required: true,
   },
-});
+})
 </script>
 
 <style scoped>
 .result {
   text-align: center;
   padding: 2rem;
+  gap: 2rem;
+  display: flex;
+  flex-direction: column;
+  align-items: center;
 }
 .lists {
   display: flex;
@@ -55,6 +60,7 @@ defineProps({
   display: flex;
   flex-direction: column;
   align-items: center;
+  gap: 5rem;
 }
 
 .image-grid {
@@ -78,7 +84,7 @@ defineProps({
   max-width: 100%;
   min-width: 60px;
   border-radius: 8px;
-  box-shadow: 0 2px 8px rgba(0,0,0,0.1);
+  box-shadow: 0 2px 8px rgba(0, 0, 0, 0.1);
   object-fit: contain;
   aspect-ratio: 1/1;
 }
@@ -105,4 +111,4 @@ defineProps({
     gap: 0.5rem;
   }
 }
-</style>
\ No newline at end of file
+</style>
diff --git a/src/main.ts b/src/main.ts
index 9c93f09..e0a3a93 100644
--- a/src/main.ts
+++ b/src/main.ts
@@ -7,7 +7,7 @@ import 'vue3-toastify/dist/index.css'
 import axios from 'axios'
 import { createPinia } from 'pinia'
 
-axios.defaults.baseURL = 'http://localhost:3000'
+axios.defaults.baseURL = 'http://localhost:3001'
 
 const pinia = createPinia()
 
diff --git a/src/route.ts b/src/route.ts
index fdc2d4e..0f5b141 100644
--- a/src/route.ts
+++ b/src/route.ts
@@ -17,16 +17,7 @@ const routes: RouteRecordRaw[] = [
     meta: {
       title: 'Smash or Pass Game',
     },
-  },
-  {
-    path: '/login',
-    name: 'login',
-    props: true,
-    component: () => import('@/components/Login.vue'),
-    meta: {
-      title: 'Login',
-    },
-  },
+  }
 ]
 const router = createRouter({
   history: createWebHistory(),
diff --git a/src/services/visualAssetService.ts b/src/services/visualAssetService.ts
index c8c72a6..0873774 100644
--- a/src/services/visualAssetService.ts
+++ b/src/services/visualAssetService.ts
@@ -1,5 +1,5 @@
 import axios from 'axios'
-import type { FrontVisualAsset, VisualAsset } from '@/types/types.ts'
+import type { FrontVisualAsset, FrontVisualAssetWithSrc, VisualAsset } from '@/types/types.ts'
 
 export const upload = async (visualAssets: VisualAsset[]): Promise<void> => {
   try {
@@ -44,10 +44,10 @@ export const fetchVisualAssetsByCollection = async (
   }
 }
 
-export const fetchVisualAssetById = async (id: string): Promise<FrontVisualAsset> => {
+export const fetchVisualAssetById = async (id: string): Promise<FrontVisualAssetWithSrc> => {
   try {
     const response = await axios.get(`/api/visualAssets/${id}`)
-    return response.data as FrontVisualAsset
+    return response.data as FrontVisualAssetWithSrc
   } catch (error) {
     console.error(`Error fetching visual asset with id ${id}:`, error)
     throw error
diff --git a/src/stores/userStore.ts b/src/stores/userStore.ts
deleted file mode 100644
index eb63d44..0000000
--- a/src/stores/userStore.ts
+++ /dev/null
@@ -1,32 +0,0 @@
-import { defineStore } from 'pinia'
-import { ref, watch } from 'vue'
-
-export const useUserStore = defineStore('user', () => {
-  const user = ref<string | null>(localStorage.getItem('user') || null)
-  const isLoggedIn = ref<boolean>(!!user.value)
-
-  function login(username: string) {
-    user.value = username
-    isLoggedIn.value = true
-    localStorage.setItem('user', username)
-  }
-
-  function logout() {
-    user.value = null
-    isLoggedIn.value = false
-    localStorage.removeItem('user')
-  }
-
-  // Keep session persistent if user changes
-  watch(user, (newUser) => {
-    if (newUser) {
-      localStorage.setItem('user', newUser)
-      isLoggedIn.value = true
-    } else {
-      localStorage.removeItem('user')
-      isLoggedIn.value = false
-    }
-  })
-
-  return { user, isLoggedIn, login, logout }
-})
diff --git a/src/types/types.ts b/src/types/types.ts
index 3d04e4b..2ae2d64 100644
--- a/src/types/types.ts
+++ b/src/types/types.ts
@@ -1,2 +1,8 @@
 export type VisualAsset = { collection: string; image: File; name: string }
-export type FrontVisualAsset = { _id: string; collection: string; imageSrc: string; name: string }
+export type FrontVisualAsset = { _id: string; collection: string; name: string; imageSrc: string }
+export type FrontVisualAssetWithSrc = {
+  _id: string
+  collection: string
+  name: string
+  imageSrc: string
+}